azure-stack-docs icon indicating copy to clipboard operation
azure-stack-docs copied to clipboard

Update install-enable-network-atc.md

Open helmste opened this issue 1 year ago • 3 comments

Recommended updates.

helmste avatar Aug 15 '24 18:08 helmste

@helmste : Thanks for your contribution! The author(s) have been notified to review your proposed change.

prmerger-automator[bot] avatar Aug 15 '24 18:08 prmerger-automator[bot]

Learn Build status updates of commit 7764292:

:warning: Validation status: warnings

File Status Preview URL Details
azure-stack/hci/upgrade/install-enable-network-atc.md :warning:Warning Details

azure-stack/hci/upgrade/install-enable-network-atc.md

  • Line 44, Column 370: [Warning: hard-coded-locale - See documentation] Link 'https://learn.microsoft.com/en-us/azure-stack/hci/deploy/network-atc?tabs=22H2' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
  • Line 44, Column 370: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/en-us/azure-stack/hci/deploy/network-atc?tabs=22H2' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@ronmiab Can you review the proposed changes?

Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged" @MicrosoftDocs/public-repo-pr-review-team

Jak-MS avatar Aug 15 '24 21:08 Jak-MS

@helmste - Thomas has reviewed and he is good with the proposed changes. Please proceed and thank you!

ronmiab avatar Aug 21 '24 13:08 ronmiab

Learn Build status updates of commit bd38ce9:

:x: Validation status: errors

Please follow instructions here which may help to resolve issue.

File Status Preview URL Details
:x:Error Details

  • [Error: CannotMergeCommit] Cannot merge commit bd38ce91a07e5fd3485acc7a7e8cfc874c68a68d in branch patch-15 of repository https://github.com/helmste/azure-stack-docs into branch main (commit ffc76242abbf8899467a9f321fd7cb9c598a247e). Please follow this documentation: https://help.github.com/articles/resolving-a-merge-conflict-using-the-command-line/ to use git.exe to resolve you content conflicts locally and then push to remote.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Learn Build status updates of commit 492daf2:

:white_check_mark: Validation status: passed

File Status Preview URL Details
azure-stack/hci/upgrade/install-enable-network-atc.md :white_check_mark:Succeeded

For more details, please refer to the build report.

For any questions, please:

#sign-off

ronmiab avatar Aug 21 '24 19:08 ronmiab

Learn Build status updates of commit 9ac3a31:

:white_check_mark: Validation status: passed

File Status Preview URL Details
azure-stack/hci/upgrade/install-enable-network-atc.md :white_check_mark:Succeeded

For more details, please refer to the build report.

For any questions, please: