Update quick-protection-app-initialization-cpp.md
Hi team Azure! Just like https://github.com/MicrosoftDocs/Azure-RMSDocs/pull/1426 and https://github.com/MicrosoftDocs/Azure-RMSDocs/pull/1412, I've made a number of changes to the MIP SDK's C++ Quickstarts.
Note that these changes are necessary to compile and run your quickstart. As it currently currently written, your code does not compile because of typos, mismatched variable names, and other errors. These changes fix it all:
- Change incorrectly-named
mAppInfotoappInfo - Change
mipContext.Shutdown()tomipContext->ShutDown()(note the->and capitalD)
I've also made a number of sorely-needed improvements to the readability of this document:
- Remove comment referencing
ReleaseAllResources(), which appears to be a C# method that was accidentally copy-pasted here - Removed
std::fooandmip::foonamespace qualification whenusing foo;was already specified. For example, the current documentation specifiesusing std::make_shared;, then proceeds to call it with a qualifyingstd::anyways... this appears to be because of copy-pasting - Alphabetize
usingdirectives; this has the added benefit of putting the more importantusing mip::directives above the less importantstdones - Commit to using
autotype specifiers instead of the current, seemingly random mixture ofautoand non-auto - Use a conventional
'\n'newline instead of the confusing"'\n"seen here
Finally, I've compiled and tested these changes on Windows and Linux, and feel free to ask questions and/or request changes. Thanks again for the work you've put into MPIP/AIP/RMS!
@lvkv - Could you please take a moment to agree to the CLA above? We can't review the PR until the CLA is completed.
@ShannonLeavitt currently waiting on employer approval for the CLA. Shouldn't be too long!
@microsoft-github-policy-service agree company="D. E. Shaw & Co., L.P."
@lvkv : Thanks for your contribution! The author(s) have been notified to review your proposed change.
@ShannonLeavitt good to go!
@msmbaldwin
IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged" @MicrosoftDocs/public-repo-pr-review-team
Any updates on this?
@msmbaldwin
Can you review this old PR?
@MicrosoftDocs/public-repo-pr-review-team
Hi, just checking in! I’d like to point teammates at these docs for onboarding, but it’s hard to do that when these intro examples don’t compile