botFramework-proactiveMessages icon indicating copy to clipboard operation
botFramework-proactiveMessages copied to clipboard

These samples are not working with version 3.9.0

Open acodallo opened this issue 8 years ago • 2 comments

I updated to v 3.9.0 and found 3 issues:

  • The ConversationStarter doesn't interrupt the active dialog. I'm using a LUIS root dialog which creates child dialogues depending on the intent.
  • stack.Poll(CancellationToken.None) was removed.
  • Microsoft.Bot.Builder.Dialogs.ResumptionCookie is marked deprecated. I tried using ConversationReference and got a NullPointerException.

Could you comment on the changes needed to make the code work with v3.9 or provide sample code?

Thanks!

acodallo avatar Aug 02 '17 23:08 acodallo

I've created a pull request to address the .net sdk ResumptionCookie/ConversationReference changes: https://github.com/MicrosoftDX/botFramework-proactiveMessages/pull/7

EricDahlvang avatar Aug 07 '17 18:08 EricDahlvang

There is a set of these same projects being maintained here: https://github.com/Microsoft/BotBuilder-Samples/tree/master/CSharp/core-proactiveMessages

EricDahlvang avatar Aug 07 '17 21:08 EricDahlvang