MichaelSB

Results 17 comments of MichaelSB

Add the possibility to add response header on WebSocket handshake request

What now follows is just my opinion on the matter... There's more to "Sec-WebSocket-Protocol" than just adding a header to make it work correctly. It may be the case in...

Add the possibility to add response header on WebSocket handshake request

What you just described is likely what I would do. Sounds good to me :D

Store custom data types into session

This restriction seems to have its origin in crow::session::multi_value, which is a (wrapped) variant using C++-17 or a struct using crow::json::wvalue instead when C++-11/14 is used. I don't see how...

support websocket compression

I'll try to add some unit-tests for this. Thanks for the review.

#692 Add the possibility to specify "Sec-WebSocket-Protocol"

I could use your split function in my websocket compression PR, if yours is merged first :D

#692 Add the possibility to specify "Sec-WebSocket-Protocol"

If I don't miss it, I think a getter is needed for the selected subprotocol in the connection. Otherwise looks good to me.

#692 Add the possibility to specify "Sec-WebSocket-Protocol"

I think that's it :) I asked for the getter, because users must be able to know which subprotocol was selected and probably switch code paths accordingly.