meteor-client icon indicating copy to clipboard operation
meteor-client copied to clipboard

Added the 'change speed with scroll wheel' functionality of the freecam module to the flight module

Open MrHello420 opened this issue 1 year ago • 2 comments

Type of change

  • [ ] Bug fix
  • [X] New feature

Description

I added the 'change speed with scroll wheel' functionality that already exists in the freecam module to the flight module. I wanted this, so I made it :)

Related issues

You can't scroll your itembar while using the flight module with this feature on.

How Has This Been Tested?

I tested it on a local world, a modded fabric server and a vanilla server. It works flawless on all tests. It also behaves exactly like the already existing functionality in the freecam module because it is mostly copied.

Checklist:

  • [X] My code follows the style guidelines of this project.
  • [X] I have added comments to my code in more complex areas.
  • [X] I have tested the code in both development and production environments.

MrHello420 avatar Sep 12 '24 13:09 MrHello420

Instead of actually changing the value of the speed setting itself, it would be better to use another value to keep track of your speed, similar to how freecam does it. Set it to the value of the speed setting when the module is activated and modify that.

https://github.com/MeteorDevelopment/meteor-client/blob/11d4efc103718710475851d952c2cb67f22b4b63/src/main/java/meteordevelopment/meteorclient/systems/modules/render/Freecam.java#L344

Wide-Cat avatar Sep 13 '24 12:09 Wide-Cat

Okay that makes sense, I will fix it when I have time.

MrHello420 avatar Sep 13 '24 15:09 MrHello420

bro did not have time 💀

Powie69 avatar Apr 15 '25 23:04 Powie69