meteor-client icon indicating copy to clipboard operation
meteor-client copied to clipboard

Rewrite `PacketUtils`

Open crosby-moe opened this issue 1 year ago • 2 comments

Type of change

  • [X] Bug fix
  • [ ] New feature

Description

Removes PacketUtilsUtils in favor of filling the PacketUtils maps using the new PlayStateFactories vanilla registry. Instead of being identified by their yarn class names, the new packet names follow the following convention: namespace:Side/UpperCamelCaseName. The namespace minecraft is implicit, mapping vanilla packets will return a name fitting Side/UpperCamelCaseName, however you can still unmap vanilla packets with and without the namespace.

To match vanilla use cases, PacketUtils and PacketListSetting methods that used to take Class<? extends Packet<?>> parameters now take PacketType<? extends Packet<?>> instead.

Since we are effectively moving away from packets named with yarn mappings to official identifiers, this means that existing PacketListSetting saved configs will be reset, and some packets may appear under completely different names.

How Has This Been Tested?

Works greate

Checklist:

  • [X] My code follows the style guidelines of this project.
  • [X] I have added comments to my code in more complex areas.
  • [X] I have tested the code in both development and production environments.

crosby-moe avatar Jul 15 '24 21:07 crosby-moe

can you update Tokyo to 1.21, Please

Abgehobenner avatar Jul 18 '24 21:07 Abgehobenner

can you update Tokyo to 1.21, Please

no and this is not the place to ask

crosby-moe avatar Jul 24 '24 00:07 crosby-moe