MeteorDevelopment
Many improvements to AutoSign
Type of change
- [x] New feature
Description
- Remove hardcoded time placeholder from MeteorStarscript.java
- Added persistent settings to save sign lines to
- Added Starscript support
- Added possibility to also apply back side of sign
- Added possibility to overwrite or keep existent text on sign When not applying anything, open edit screen normally
How Has This Been Tested?
- Placing many signs, in diffrent situations
- On a local vanilla server.
- Some SMP servers.
Checklist:
- [x] My code follows the style guidelines of this project.
- [x] I have added comments to my code in more complex areas.
- [x] I have tested the code in both development and production environments.
what was wrong with the time placeholder? it looks correct from looking at the code
It was not wrong, but it did always overwrite the time placeholder from the Starscript StandardLib.timeFormat object.
It was not wrong, but it did always overwrite the time placeholder from the Starscript StandardLib.timeFormat object.
ahh i see
While testing I found some bigger issues, need to look into how to solve these.
While testing I found some bigger issues, need to look into how to solve these.
what are the issues?
First something unrelated: sign.getEditor() is always null for me?
So the module works fine on a server which accepts sign editing (vanilla). But I also tested it on servers where editing is not possible, this turned out to have negative side effects, while having back sign writing enabled. Double placed signs on 2b2t (2b2t doesn't allow editing), every second sign empty on constantiam (older mc version).
I tried to use sign.getEditor() to verify if the BlockInteraction was successfull and if the sign could be edited.
Is checked and tested. Added a warning, if server doesn't support back sign editing.
Hi, I would really like, to see this merged. :) Also if https://github.com/MeteorDevelopment/starscript/pull/21 is not yet being merged.
Or is there something else holding up this PR?