meteor-client icon indicating copy to clipboard operation
meteor-client copied to clipboard

FakePlayer Rewrite

Open CrytoPal opened this issue 2 years ago • 8 comments

Type of change

  • [ ] Bug fix
  • [x] New feature

Description

Lets the Fake Player take Damage and pop Totems. It also lets you play movement Recordings.

Related issues

none

How Has This Been Tested?

Trial and Error, Works with multiple Fake Player Entities as well.

Checklist:

  • [x] My code follows the style guidelines of this project.
  • [x] I have added comments to my code in more complex areas.
  • [x] I have tested the code in both development and production environments.

CrytoPal avatar Dec 16 '23 21:12 CrytoPal

I'm not sure about all these changes. When the damage setting is disabled you can still hit the entity and it simulates taking damage, just without a totem, which it wasn't like before. The movement recording thing seems really finicky; it isn't clear when it's recording and when it isn't, and it's pretty easy to completely break it if you start recording and playing at the same time with loop recording enabled.

Wide-Cat avatar Dec 22 '23 14:12 Wide-Cat

I think this just needs a lot more polish. When it works it's pretty good but it just feels like this was committed before it's actually done.

Wide-Cat avatar Dec 22 '23 14:12 Wide-Cat

@Wide-Cat I fixed the bugs you mentioned.

CrytoPal avatar Dec 22 '23 23:12 CrytoPal

you could add a setting to allow them to be in network player list

tympanicblock61 avatar Jan 25 '24 00:01 tympanicblock61

you could add a way to send a message from one of the fake players

tympanicblock61 avatar Jan 25 '24 00:01 tympanicblock61

you could instead of having the settings global have them for each fakeplayer (this is just a suggestion dont really think you will add it)

tympanicblock61 avatar Jan 25 '24 00:01 tympanicblock61