cpp-build-analyzer icon indicating copy to clipboard operation
cpp-build-analyzer copied to clipboard

! for some reason some template names are not found

Open mihaisebea opened this issue 5 years ago • 2 comments

Unfortunately is not easy to create a simple reproducible case. It seems that SpecializationID is 0. I will try to look more into this.

mihaisebea avatar Sep 01 '20 22:09 mihaisebea

Hi Mihai, thank you for another fix!

I guess the PR can be approved, but I'd like to have some more info on the issue before merging it. Can you please answer these questions?

  • When you collected the trace, which MSVC version was the project compiled with?
  • Can you check whether those Unknown templates timeElapsed under the default time to be ignored in the BuildTimeline.json report? I think it's 10ms right now. If it is, it means we'd have this same issue in the timeline report if we passed the timeline_ignore_templates_under argument and it might mean it's a bug in the compiler. Otherwise that'd be an issue in this report.

Thanks 👍

MetanoKid avatar Sep 04 '20 17:09 MetanoKid

Hi @MetanoKid I used Visual Studio 2019 16.7.2 Seems the default is indeed 10ms but I have templates that take well over 500ms.

As far as i'm debugging this, in this function:

void TemplateInstantiationsAnalyzer::OnTemplateInstantiation(const CppBI::Activities::TemplateInstantiation& templateInstantiation)
{

there are plenty instantiations that have PrimaryTemplateSymbolKey and SpecializationSymbolKey 0 (zero) And this is what the event looks like. image

mihaisebea avatar Sep 06 '20 21:09 mihaisebea