ddi-xslt icon indicating copy to clipboard operation
ddi-xslt copied to clipboard

Remove hard coded values in ddi_2_5-cessda_eqb.xslt

Open borsna opened this issue 3 years ago • 2 comments

Hard coded values should be avoided. Some example of hard coded values in the XSLT:

holdings: https://github.com/MetadataTransform/ddi-xslt/blob/767774ac3c1add9fd944ed40e412ed1968c2fdda/transformations/cessda-eqb/from-ddi-2.5/ddi_2_5-cessda_eqb.xslt#L85

qstn@xml:lang: https://github.com/MetadataTransform/ddi-xslt/blob/master/transformations/cessda-eqb/from-ddi-2.5/ddi_2_5-cessda_eqb.xslt#L170

labl@xml:lang: https://github.com/MetadataTransform/ddi-xslt/blob/master/transformations/cessda-eqb/from-ddi-2.5/ddi_2_5-cessda_eqb.xslt#L209

var@xml:lang: https://github.com/MetadataTransform/ddi-xslt/blob/master/transformations/cessda-eqb/from-ddi-2.5/ddi_2_5-cessda_eqb.xslt#L136

Values should come for source XML document or via xsl:param

borsna avatar Apr 25 '22 07:04 borsna

@zibertg could you take a look at these cases? The XSLT works fine but i think some hard coded values should be fixed so the XSLT works in a more general way for any DDI 2.5 XML-file.

Best regards, Olof

borsna avatar Apr 25 '22 07:04 borsna

Agreed, for reuse of the XSLT hardcoded fields should be removed. Uploaded the updated XSLT.

zibertg avatar May 03 '22 07:05 zibertg