metamask-mobile icon indicating copy to clipboard operation
metamask-mobile copied to clipboard

Feat/smart tx txcontroller v13 – DO NOT REVIEW

Open infiniteflower opened this issue 1 year ago • 14 comments

[!WARNING] DO NOT REVIEW – Not intended for review

PR for STX + TransactionController v13

Description

This PR does the following:

  1. Implements Smart Transactions (STX) across all transaction types.
  2. Shows a Status Screen that appears after the user initiates the transaction
  3. Shows an opt in modal for STX

Related issues

Fixes: n/a

Manual testing steps

Since STX touches all transaction types, here are the major areas for testing:

Send

  1. Go to Send
  2. Pick an account to send to
  3. Send
  4. Observe new STX Status Page

MM Swaps

  1. Go to MM Swaps
  2. Do a Swap from ETH > ERC20
  3. Observe new STX Status Page

Dapp

  1. Go to in app browser
  2. Go to Uniswap
  3. Do a swap
  4. Observe new STX Status Page

Screenshots/Recordings

Refer to #9565

Before

n/a

After

https://github.com/MetaMask/metamask-mobile/assets/139582705/548adb18-5f59-412e-ba83-924d710be52e

https://github.com/MetaMask/metamask-mobile/assets/139582705/df11470c-2721-461e-b30a-ddc015d1441b

https://github.com/MetaMask/metamask-mobile/assets/139582705/9f7bc71f-89dd-439f-a845-c2f2f3cb607e

https://github.com/MetaMask/metamask-mobile/assets/139582705/d798ba4b-d237-40a5-a0a3-68a21ab16b63

https://github.com/MetaMask/metamask-mobile/assets/139582705/80a9188a-a63d-4c02-9a6b-036881203618

https://github.com/MetaMask/metamask-mobile/assets/139582705/674004be-b356-408d-a92d-7710f2506f76

https://github.com/MetaMask/metamask-mobile/assets/139582705/0fa4d4db-b53c-4acc-b7f7-0261c64c22bf

https://github.com/MetaMask/metamask-mobile/assets/139582705/0b2c4711-3a06-4482-8c19-4fa9064e740f

https://github.com/MetaMask/metamask-mobile/assets/139582705/fc8b46ce-e7f1-4adb-8ef5-6f4dd60a545c

infiniteflower avatar May 06 '24 22:05 infiniteflower

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar May 06 '24 22:05 github-actions[bot]

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/@ethereumjs/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@spruceid/[email protected]

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

socket-security[bot] avatar May 06 '24 22:05 socket-security[bot]

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/[email protected] None 0 44.6 kB mcmire
npm/@metamask/[email protected] network +6 884 kB metamaskbot
npm/@metamask/[email protected] network Transitive: environment, filesystem +41 10.6 MB mcmire
npm/@metamask/[email protected] None 0 36.9 kB metamaskbot

🚮 Removed packages: npm/@metamask/[email protected]

View full report↗︎

socket-security[bot] avatar May 06 '24 22:05 socket-security[bot]

@SocketSecurity ignore npm/@metamask/[email protected] @SocketSecurity ignore npm/@ethereumjs/[email protected] @SocketSecurity ignore npm/@spruceid/[email protected] @SocketSecurity ignore npm/@metamask/[email protected]

infiniteflower avatar May 06 '24 23:05 infiniteflower

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: f2f050a584900e8767ed892af0347d87b8171947 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/b6f72791-b533-41ed-b440-85701c3096fe

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar May 07 '24 03:05 github-actions[bot]

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: f2f050a Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/b6f72791-b533-41ed-b440-85701c3096fe

@infiniteflower FYI

legobeat avatar May 07 '24 03:05 legobeat

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 94e35bc568bddda00a95bb87bd3d8f0364675a6f Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ee0148b2-09bf-464f-a0e7-aabc369fb646

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar May 07 '24 14:05 github-actions[bot]

@SocketSecurity ignore npm/@metamask/[email protected]

infiniteflower avatar May 07 '24 19:05 infiniteflower

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 52cd7b62f51e6212798a04fb537a6cb725fb61b7 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/536c2863-8125-4f85-8f1d-e86ef7cb1d9a

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar May 07 '24 19:05 github-actions[bot]

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 08f976bdf9e8d62f2756632516afe2b4d9c88122 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e6b78eb5-811a-4687-a55b-ffe68a57b179

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar May 07 '24 19:05 github-actions[bot]

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 926b94c7e75ea79cb204630a94f1b3458795e080 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/8a379783-7b7a-49d8-a428-608739a936e0

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar May 08 '24 23:05 github-actions[bot]

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: c0d0b87e343497389d4d8a68ebeb48ceae004de9 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/19054418-49f5-47c5-aab0-9e6036f102c6

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar May 10 '24 23:05 github-actions[bot]

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: c5e6e16a8df12028076c62e55055d825f260184d Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/5e57a589-d63f-4f4b-aabf-08abe821ef2f

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar May 11 '24 01:05 github-actions[bot]

This PR has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 7 days. Thank you for your contributions.

github-actions[bot] avatar Aug 14 '24 03:08 github-actions[bot]

This PR was closed because there has been no follow up activity in 7 days. Thank you for your contributions.

github-actions[bot] avatar Aug 21 '24 04:08 github-actions[bot]