metamask-mobile
metamask-mobile copied to clipboard
E2E: Clean up Assertions class
What is this about?
The assertion class has a few methods that might be challenging to read/understand. We should clean up the code by:
- Renaming assertion methods so they explicitly tell their purpose
- Remove redundancies
- Renaming assertion methods so they explicitly tell their purpose
ƒor example: checkIfVisible this method should specify if it is a element, text, toggle is visible.
- Remove redundancies
ƒor example: We have two methods that check if an element has text checkIfElementToHaveText, checkIfHasText
- Revisit how we perform assertions on the elements.
Scenario
No response
Design
No response
Technical Details
No response
Threat Modeling Framework
No response
Acceptance Criteria
E2E tests should pass on CI and locally.
Stakeholder review needed before the work gets merged
- [ ] Engineering (needed in most cases)
- [ ] Design
- [ ] Product
- [ ] QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
- [ ] Security
- [ ] Legal
- [ ] Marketing
- [ ] Management (please specify)
- [ ] Other (please specify)
References
No response