metamask-mobile icon indicating copy to clipboard operation
metamask-mobile copied to clipboard

[Bug]: Having all the browser tabs close I can Connect Accounts to the previous dapp selected

Open seaona opened this issue 2 years ago • 3 comments

Describe the bug

Problem: whenever I close all the browser tabs, if I click on the Account icon I can see how I can connect accounts to the previous dapp open

Expected behavior

If there is no dapp open I should not be able to connect accounts

Screenshots/Recordings

https://github.com/MetaMask/metamask-mobile/assets/54408225/eca8ba04-11b7-4d83-903b-a5408891f0ed

Steps to reproduce

  1. Go to the wallet browser
  2. Open the test dapp https://metamask.github.io/test-dapp/
  3. Connect one account
  4. Now click on the window icon at the bottom
  5. Close all the tabs
  6. Click in the Account icon
  7. See how you can connect more accounts to the test dapp

Error messages or log output

No response

Version

found in 7.16 but possibly an old issue

Build type

None

Device

Pixel 6

Operating system

Android

Additional context

No response

Severity

No response

seaona avatar Feb 02 '24 11:02 seaona

We thank you for reporting the issue and we have assigned it to a team in which it will be looked at.

FoxxyMartin avatar Feb 14 '24 06:02 FoxxyMartin

Comments from @tommasini @chrisleewilcox :

  • We need to make sure we do not persist the last visited dapp when a browser tab gets closed.
  • We should just show the network icon, but not the account icon when no tab is open.
  • There is a potential security concern if user can connect an account without any tab opened.

gauthierpetetin avatar Feb 16 '24 16:02 gauthierpetetin

This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 7 days. Thank you for your contributions.

github-actions[bot] avatar May 16 '24 16:05 github-actions[bot]

This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 7 days. Thank you for your contributions.

github-actions[bot] avatar Aug 14 '24 20:08 github-actions[bot]