[Bug]: Having all the browser tabs close I can Connect Accounts to the previous dapp selected
Describe the bug
Problem: whenever I close all the browser tabs, if I click on the Account icon I can see how I can connect accounts to the previous dapp open
Expected behavior
If there is no dapp open I should not be able to connect accounts
Screenshots/Recordings
https://github.com/MetaMask/metamask-mobile/assets/54408225/eca8ba04-11b7-4d83-903b-a5408891f0ed
Steps to reproduce
- Go to the wallet browser
- Open the test dapp https://metamask.github.io/test-dapp/
- Connect one account
- Now click on the window icon at the bottom
- Close all the tabs
- Click in the Account icon
- See how you can connect more accounts to the test dapp
Error messages or log output
No response
Version
found in 7.16 but possibly an old issue
Build type
None
Device
Pixel 6
Operating system
Android
Additional context
No response
Severity
No response
We thank you for reporting the issue and we have assigned it to a team in which it will be looked at.
Comments from @tommasini @chrisleewilcox :
- We need to make sure we do not persist the last visited dapp when a browser tab gets closed.
- We should just show the network icon, but not the account icon when no tab is open.
- There is a potential security concern if user can connect an account without any tab opened.
This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 7 days. Thank you for your contributions.
This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 7 days. Thank you for your contributions.