metamask-mobile icon indicating copy to clipboard operation
metamask-mobile copied to clipboard

After completing a transaction with mobile device screen locked, user is returned to "Confirm" as though transaction was not completed

Open plasmacorral opened this issue 3 years ago • 1 comments

Description

Android 12 Pixel 3a Build 952

If mobile device screen locks before tx gets broadcast, on unlock the user is returned to Confirm instead of wallet/activity view. If user taps "Confirm with Ledger" at this point, an "Invalid Amount" error is presented.

Curiously, if Advanced>Customize Transaction Nonce is enabled after being returned to Confirm, tapping edit presents a nonce value of "ined".

Reproduction steps:

  1. Have Ledger paired with configured MMM
  2. Have Ledger set to PIN/Screensaver 10 minutes, Blind signing enabled, debug data not displayed, Nonce displayed
  3. Have Mobile device screen timeout set to 30 seconds (settings>display)
  4. Have MMM set to the default 30 seconds at Settings>Security & Privacy> Auto-lock
  5. Have custom nonce enabled in MMM Settings>Advanced
  6. Be on a testnet and have assets available to send
  7. Tap send from wallet view/ drawer or activity page
  8. Select recipient tap next
  9. Enter amount and tap next
  10. Tap "Confirm with Ledger"
  11. Allow mobile screen to be dark between 30-45 seconds
  12. Tap "approve and send" on Ledger
  13. Unlock mobile device, if brought to login authentication try again because you were a bit too slow.
  14. Not that Confirm is presented
  15. Tapping "Confirm with Ledger" produces an error "Invalid amount Go to faucet"
  16. Tapping edit next to Nonce presents a non-numeric value

Technical Details

  • The user should be returned to wallet view or activity view after completing a transaction

Acceptance Criteria

  • User is not presented information that undermines confidence in the fact that the transaction was just sent

Scenario: Mobile device sleep

  • GIVEN a user is has initiated a transaction and has tapped "Confirm with Ledger"
  • WHEN the mobile device screen locks
  • AND the user taps to "accept and send" on Ledger
  • THEN the transaction should be broadcast to the network
  • WHEN the user unlocks the mobile device
  • AND the user is NOT directed to the login authentication
  • THEN the user should be returned to wallet view or activity view
  • AND should NOT see "Confirm with Ledger" CTA

References

  • This video is playing at 2x speed, but I observed the dark screen on the mobile device for approximately 35 seconds before confirming on Ledger: https://recordit.co/s87oaWa3uA

  • non-numeric nonce:

plasmacorral avatar Sep 15 '22 22:09 plasmacorral

possibly related to #4915

plasmacorral avatar Sep 16 '22 14:09 plasmacorral

This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 7 days. Thank you for your contributions.

github-actions[bot] avatar May 27 '23 00:05 github-actions[bot]

This issue was closed because it has been stalled for 7 days with no activity. If you feel this was closed in error please reopen and provide evidence on the current production app. Thank you for your contributions.

github-actions[bot] avatar Jun 04 '23 17:06 github-actions[bot]