metamask-mobile icon indicating copy to clipboard operation
metamask-mobile copied to clipboard

Transactions shows wrong scan link

Open Cal-L opened this issue 3 years ago • 0 comments

Description

Transactions shows wrong scan link

image

Video of issue - https://recordit.co/oZ9pNjXmfK

Steps to reproduce from @chrisleewilcox :

  • After new install add Avalanche network using add popular networks
  • Execute swap on Avalanche
  • Add Binance network using add popular networks
  • Execute swap on Binance
  • The transactions will show view history on Avalanche in Activity > Transactions (This is where the scan link shows the wrong chain - Reference video)

Technical Details

  • The issue is most likely located in components/UI/Transactions/index.js since both Asset and Activity flows use this components + the issue has been seen in both places.
  • More specifically - It might be related to storing this.state.rpcBlockExplorer in state and/or being a class component.
  • A refactor to functional component is highly recommended and would be a good place to start.

Acceptance Criteria

  • Transactions from Assets and Activity should both show correct scan links

Scenario: xxxx

  • GIVEN a user is in x state
  • WHEN a user does x
  • AND a user does x
  • THEN x should occur

Cal-L avatar Jul 11 '22 18:07 Cal-L