fix: accounts not syncing between devices bug

[Jonathansoufer]

Description

This PR fixed an issue preventing mobile accounts to sync its states (enable/disable) with other clients (platform and extension). NOTIFY-1218

Related issues

Fixes:

Manual testing steps

1. Import the same SRP on Mobile
2. Make sure all accounts are visible on both devices/platforms. If not, import all accounts
3. Switch Notifications state in account "A" on extension.
4. Go to Notifications Settings on mobile and see if the state is propagated.
5. Switch back on mobile
6. Go to extension and see if state is propagated.

Screenshots/Recordings

Before

After

https://github.com/user-attachments/assets/860e2e46-f08a-45fd-b965-a9948ef59630

Pre-merge author checklist

• [x] I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• [x] I've completed the PR template to the best of my ability
• [x] I’ve included tests if applicable
• [x] I’ve documented my code using JSDoc format if applicable
• [x] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions[bot]]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[github-actions[bot]]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 2f355183b96dc5552d22026c1b4d32c41468b44d Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/dc24a3c7-b7c3-42d3-b268-deea8a0e379d

[!NOTE]

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[github-actions[bot]]

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 9598c7e30342bb1ff1647bfe7c81e4147f2781f0 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/4093b4e3-5c7a-4dbc-961c-970a4ad0bcc3

[!NOTE]

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[!TIP]

• Check the documentation if you have any doubts on how to understand the failure on bitrise

[Daniel-Cross]

Looks good @Jonathansoufer, just a couple of comments.

Also, what's the purpose of the skip-sonar-cloud label? I see you're hitting the quality gate threshold, I would prefer it if we ran as many checks as possible against all changes.

[salimtb]

great work @Jonathansoufer , i just left two small comments regarding consistency and perf improvement

[github-actions[bot]]

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: cf2afc91b8bcac0e1b7ff50c7a312cecaa8d8333 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/846e4a65-1ab7-49a3-bbf4-8ce843937bd8

[!NOTE]

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[!TIP]

• Check the documentation if you have any doubts on how to understand the failure on bitrise

[github-actions[bot]]

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: ee9f14316f406ff43b155e2645d1f0374ffae85c Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/6c67841a-14c3-4f41-beda-1029c3e6f746

[!NOTE]

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[!TIP]

• Check the documentation if you have any doubts on how to understand the failure on bitrise

[github-actions[bot]]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: cb13aec734c48f8572f7d6e2cd7da0e7cc5b6f98 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/3f6e24a3-1659-4518-8997-06f2899fdb4f

[!NOTE]

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[github-actions[bot]]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 97b6f0aae38c92107352d12f81bebf9f685ca11e Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/3526233a-47f1-42ce-9a9b-638a680a77f3

[!NOTE]

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[sonarqubecloud[bot]]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
71.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud