metamask-mobile icon indicating copy to clipboard operation
metamask-mobile copied to clipboard

fix(2804): Right margin was to wide and looked broken compared to left

Open EtherWizard33 opened this issue 1 year ago • 3 comments

Description

This fixes the right margin of the modal that shows when switching network

Related issues

Contributes to solve issue: https://github.com/MetaMask/MetaMask-planning/issues/2796

Manual testing steps

I have added screenshot below to see how it looks.

  1. Go to the in-app brower on the mobile wallet, connect to a dapp like uniswap
  2. Switch netowrk to a network for which permission was not added before
  3. A modal will show up and show have the same margin width on the right side as on the left side.

Screenshots/Recordings

Before After
Screenshot 2024-04-18 at 3 56 43 PM Screenshot 2024-04-18s at 3 56 43 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

EtherWizard33 avatar Oct 11 '24 21:10 EtherWizard33

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar Oct 11 '24 21:10 github-actions[bot]

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: cb7207a5adbb3a71cbd57314d1b04d5520c48705 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/28158468-4667-490b-9b75-5191d4cc4c76

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar Oct 18 '24 18:10 github-actions[bot]

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: a61530542bdba1aaf799ee9a83be13df5cad68b0 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/0ed3fdac-e6ad-40d8-a17d-77d7d6267a4a

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar Oct 21 '24 21:10 github-actions[bot]

This PR has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 7 days. Thank you for your contributions.

github-actions[bot] avatar Feb 16 '25 23:02 github-actions[bot]

This PR was closed because there has been no follow up activity in 7 days. Thank you for your contributions.

github-actions[bot] avatar Feb 24 '25 00:02 github-actions[bot]