fixes: connectWith sdk
Description
Implementation of async key exchange created a regression to handle connectWith rpc calls. This fixes the issue as well as an invalid icon being displayed on each new connection.
Related issues
Fixes: https://github.com/MetaMask/metamask-mobile/issues/10848
Manual testing steps
- Go to this page...
Screenshots/Recordings
Before
After
Pre-merge author checklist
- [x] I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using JSDoc format if applicable
- [x] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
Pre-merge reviewer checklist
- [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.
Bitrise
✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅
Commit hash: e09e097cfc7482da41ce866c37e474954be421fc Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c989d614-9b09-42d9-909b-7e1e151f688b
[!NOTE]
- You can kick off another
pr_smoke_e2e_pipelineon Bitrise by removing and re-applying theRun Smoke E2Elabel on the pull request
Quality Gate passed
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
82.8% Coverage on New Code
0.0% Duplication on New Code
TC: Given a user opens a Javascript dapp And taps connectAndSign Then he should get a connection and a signinig approval on the MetaMask Mobile Wallet
https://github.com/user-attachments/assets/a226af8e-3acf-41d3-8c47-0177b75794ee