metamask-mobile icon indicating copy to clipboard operation
metamask-mobile copied to clipboard

fixes: connectWith sdk

Open abretonc7s opened this issue 1 year ago • 2 comments

Description

Implementation of async key exchange created a regression to handle connectWith rpc calls. This fixes the issue as well as an invalid icon being displayed on each new connection.

Related issues

Fixes: https://github.com/MetaMask/metamask-mobile/issues/10848

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

abretonc7s avatar Aug 28 '24 14:08 abretonc7s

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar Aug 28 '24 14:08 github-actions[bot]

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: e09e097cfc7482da41ce866c37e474954be421fc Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c989d614-9b09-42d9-909b-7e1e151f688b

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar Aug 29 '24 08:08 github-actions[bot]

TC: Given a user opens a Javascript dapp And taps connectAndSign Then he should get a connection and a signinig approval on the MetaMask Mobile Wallet

https://github.com/user-attachments/assets/a226af8e-3acf-41d3-8c47-0177b75794ee

christopherferreira9 avatar Aug 29 '24 10:08 christopherferreira9