fix: Wrong or missing analytics `request_source`
Description
Fixes missing analytics data for events:
-
DAPP_TRANSACTION_COMPLETED -
SIGNATURE_APPROVED -
CONTRACT_ADDRESS_COPIED -
APPROVAL_PERMISSION_UPDATED -
APPROVAL_STARTED -
SEND_TRANSACTION_STARTED -
SEND_TRANSACTION_COMPLETED
when there's an error in getting the analytics data, the methods used to return an empty object {}. This PR tries to send at least some basic data that is fundamental for analytics of events while waiting for the fix of the method and a better understanding of what's really causing the error.
Related issues
Fixes:
Manual testing steps
- Go to this page...
Screenshots/Recordings
Before
After
Pre-merge author checklist
- [x] I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
- [x] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using JSDoc format if applicable
- [x] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
Pre-merge reviewer checklist
- [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.
Bitrise
❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌
Commit hash: 98389fa4d5969bb30822c3b97f0307c6bbf640cd Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/868b2ebe-f677-43ed-be6c-b0ca57d4bd09
[!NOTE]
- You can kick off another
pr_smoke_e2e_pipelineon Bitrise by removing and re-applying theRun Smoke E2Elabel on the pull request
Quality Gate passed
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
63.8% Coverage on New Code
0.0% Duplication on New Code