metamask-mobile icon indicating copy to clipboard operation
metamask-mobile copied to clipboard

fix: Wrong or missing analytics `request_source`

Open andreahaku opened this issue 1 year ago • 1 comments

Description

Fixes missing analytics data for events:

  • DAPP_TRANSACTION_COMPLETED
  • SIGNATURE_APPROVED
  • CONTRACT_ADDRESS_COPIED
  • APPROVAL_PERMISSION_UPDATED
  • APPROVAL_STARTED
  • SEND_TRANSACTION_STARTED
  • SEND_TRANSACTION_COMPLETED

when there's an error in getting the analytics data, the methods used to return an empty object {}. This PR tries to send at least some basic data that is fundamental for analytics of events while waiting for the fix of the method and a better understanding of what's really causing the error.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

andreahaku avatar Aug 19 '24 14:08 andreahaku

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar Sep 05 '24 13:09 github-actions[bot]

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 98389fa4d5969bb30822c3b97f0307c6bbf640cd Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/868b2ebe-f677-43ed-be6c-b0ca57d4bd09

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar Sep 05 '24 14:09 github-actions[bot]