metamask-extension icon indicating copy to clipboard operation
metamask-extension copied to clipboard

feat(metametrics): use specific `account_hardware_type` for OneKey devices

Open dawnseeker8 opened this issue 1 year ago • 9 comments

Description

Currently extension supports connecting to OneKey via Trezor, but we don't have specific metrics to log this when importing the accounts.

Now, the account_hardware_type will be set to OneKey via Trezor for AccountAdded metric when using OneKey devices.

Open in GitHub Codespaces

Related issues

Fixes: https://github.com/MetaMask/accounts-planning/issues/586

Manual testing steps

N/A

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

dawnseeker8 avatar Sep 20 '24 01:09 dawnseeker8

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar Sep 20 '24 01:09 github-actions[bot]

Builds ready [6297cf3]
Page Load Metrics (1886 ± 61 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint22820791716499240
domContentLoaded16492112185312158
load16922137188612861
domInteractive17146442813
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 346 Bytes (0.01%)
  • ui: 163 Bytes (0.00%)
  • common: 163 Bytes (0.00%)

metamaskbot avatar Oct 08 '24 08:10 metamaskbot

Builds ready [02b8df2]
Page Load Metrics (1737 ± 97 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint23724451658380183
domContentLoaded15342346170217685
load15622455173720297
domInteractive26112512311
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 346 Bytes (0.01%)
  • ui: 149 Bytes (0.00%)
  • common: 329 Bytes (0.00%)

metamaskbot avatar Oct 08 '24 13:10 metamaskbot

Lint failing

This have been resolved.

dawnseeker8 avatar Oct 09 '24 10:10 dawnseeker8

Metric verified on Mixpanel using locally deployed build. image.png

vivek-consensys avatar Oct 10 '24 03:10 vivek-consensys

Builds ready [410ed88]
Page Load Metrics (2087 ± 196 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint161930662089419201
domContentLoaded161030532048393189
load161830702087408196
domInteractive2198502210
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 428 Bytes (0.01%)
  • ui: 149 Bytes (0.00%)
  • common: 329 Bytes (0.00%)

metamaskbot avatar Oct 14 '24 13:10 metamaskbot

Builds ready [826d5c2]
Page Load Metrics (2016 ± 345 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint161649382023742356
domContentLoaded161148051994723347
load161648192016719345
domInteractive18221594823
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 428 Bytes (0.01%)
  • ui: 149 Bytes (0.00%)
  • common: 329 Bytes (0.00%)

metamaskbot avatar Oct 14 '24 13:10 metamaskbot

Builds ready [8d306b2]
Page Load Metrics (1881 ± 75 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint28122021607561269
domContentLoaded16352076184213866
load16792227188115675
domInteractive1680432010

metamaskbot avatar Oct 15 '24 12:10 metamaskbot

Builds ready [c4ebe07]
Page Load Metrics (1989 ± 109 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint29624681905432207
domContentLoaded169024601949222107
load174024731989227109
domInteractive20107542211
backgroundConnect9134373416
firstReactRender502781115627
getState467262311
initialActions01000
loadScripts12321967144520297
setupStore1098332713
uiStartup190027212239246118
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 431 Bytes (0.01%)
  • ui: 153 Bytes (0.00%)
  • common: 332 Bytes (0.00%)

metamaskbot avatar Oct 21 '24 07:10 metamaskbot

Builds ready [b786deb]
Page Load Metrics (1953 ± 118 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint171225611951243117
domContentLoaded170225401916229110
load171225511953247118
domInteractive16191634823
backgroundConnect8234354924
firstReactRender481961003316
getState591232612
initialActions01000
loadScripts12351970141417584
setupStore1297332713
uiStartup192331582193301145
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 431 Bytes (0.01%)
  • ui: 153 Bytes (0.00%)
  • common: 333 Bytes (0.00%)

metamaskbot avatar Oct 21 '24 09:10 metamaskbot