metamask-extension icon indicating copy to clipboard operation
metamask-extension copied to clipboard

[Bug]: The Zero address does not pass input validation for Send and Contact but it does if it's added from a Dapp

Open seaona opened this issue 3 years ago • 1 comments

Describe the bug

Problem: when I try to send to the 0 address I see that MM takes it as an invalid address. This also happens when I try to add a Contact with the 0 address. However, I can bypass this validations by injecting the 0 address from a dapp. Therefore I can send to 0 address as well as add it as a contact.

This is a missmatch and should be either addressed as we accept everywhere the 0 address (I would opt for that) or we don't.

https://user-images.githubusercontent.com/54408225/182210543-c0f54c96-2c13-4a29-b930-708ef2d934ec.mp4

Steps to reproduce

  1. Try to send a tx to the zero address 0x0000000000000000000000000000000000000000 - you won't be able
  2. Try to add a contact with the zero address - you won't be able
  3. Edit Test-Dapp repo and include the receipient for a SendEIPtx function, the zero address
  4. Click the button for Send - see how it is possible
  5. Now add this address directly from the MM popup - it's also possible

Error messages or log output

No response

Version

10.19.0

Build type

No response

Browser

Chrome

Operating system

Linux

Hardware wallet

No response

Additional context

No response

seaona avatar Aug 01 '22 17:08 seaona

Related to https://github.com/MetaMask/metamask-extension/issues/7154

bschorchit avatar Aug 03 '22 20:08 bschorchit

This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 45 days if there is no further activity. The MetaMask team intends on reviewing this issue before close, and removing the stale label if it is still a bug. We welcome new comments on this issue. We do not intend on closing issues if they report bugs that are still reproducible. Thank you for your contributions.

github-actions[bot] avatar Sep 03 '23 16:09 github-actions[bot]

This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 45 days if there is no further activity. The MetaMask team intends on reviewing this issue before close, and removing the stale label if it is still a bug. We welcome new comments on this issue. We do not intend on closing issues if they report bugs that are still reproducible. Thank you for your contributions.

github-actions[bot] avatar Dec 04 '23 02:12 github-actions[bot]

This issue was closed because there has been no follow up activity in the last 45 days. If you feel this was closed in error, please reopen and provide evidence on the latest release of the extension. Thank you for your contributions.

github-actions[bot] avatar Jan 18 '24 02:01 github-actions[bot]