eth-method-registry icon indicating copy to clipboard operation
eth-method-registry copied to clipboard

Migrate from `ethjs` to `ethers`

Open Gudahtt opened this issue 4 years ago • 4 comments

ethers is better maintained than ethjs, and we've been migrating many of our packages to use it. This should work equivalently.

This will be a breaking change because this will change public properties of the method registry class.

Gudahtt avatar Feb 10 '21 19:02 Gudahtt

I forgot to update the readme!

Edit: README has been updated; this should be good to go now.

Gudahtt avatar Feb 10 '21 20:02 Gudahtt

@Gudahtt could this be revisted? I think removing ethjs across all the dependencies we maintain would be a solid move considering its staleness.

brad-decker avatar Mar 31 '23 16:03 brad-decker

Happy to take this on, but i'd like more clarification on the issue you highlighted.

brad-decker avatar Mar 31 '23 16:03 brad-decker

I think what we want here is a type that represents an EIP-1193 provider. Then we can pass a provider that implements that interface (e.g. an Ethers provider) without being tied to a specific version of that specific library

Gudahtt avatar Mar 31 '23 16:03 Gudahtt