eth-ledger-bridge-keyring icon indicating copy to clipboard operation
eth-ledger-bridge-keyring copied to clipboard

Feat: use vite build tools to replace the outdated gulp and browserify to support ledger clear signing requirement

Open dawnseeker8 opened this issue 1 year ago • 2 comments

description:

This PR is prerequirement change to support ledger clear sign feature. This PR link to following issue and project plan #217 clear sign feature plan

The PR has done following change:

  1. remove all old gulp and browserify lib dependancy in package.json
  2. add yarn 4.3.1 Pnp as pacakge management tools for the project.
  3. Add vite to our project list ( i have compared and test parcel js which ledger team recommend, and i have created branch to use parceljs for this feature, and it work with subpath export feature, however i find out parcel is not good enough for customisation and split the big files into chunk during build, therefore, i choose better build tools call vitejs for this feature)
  4. update the ledgerHQ library to latest to support clear signing feature.
  5. Customise the vite.config.js file to support legacy browsers and modern browsers. (will bundle both legacy minified files and modern minified files to support both modern browsers and legacy browsers)

:warning: Merge to gh-pages may deploy the code to live in the public, which will affect the metamask extension user. so we need to double check this change didn't break the current ledger feature in metamask extension before merge the PR.

dawnseeker8 avatar Aug 13 '24 11:08 dawnseeker8

Report is too large to display inline. View full report↗︎

Next steps

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

socket-security[bot] avatar Aug 13 '24 11:08 socket-security[bot]

@SocketSecurity ignore

dawnseeker8 avatar Nov 28 '24 12:11 dawnseeker8

Report too large to display inline

View full report↗︎

socket-security[bot] avatar Nov 29 '24 00:11 socket-security[bot]