eth-json-rpc-middleware icon indicating copy to clipboard operation
eth-json-rpc-middleware copied to clipboard

Add eth_getPlumeSignature RPC handler

Open rrrliu opened this issue 2 years ago • 4 comments

Context: Implementation of a novel deterministic ECDSA signature scheme in MetaMask https://eprint.iacr.org/2022/1255

Add handler for eth_getPlumeSignature to unblock https://github.com/MetaMask/metamask-extension/pull/17482, as we'd like to use this new RPC method to generate the signature + other necessary SNARK inputs.

rrrliu avatar Feb 21 '23 10:02 rrrliu

We should ensure that the extension team wishes to accept this change before we include it here. Just wanted to give you a heads up before you do more work on these tests, that it might be better to get buy-in from that team first.

Gudahtt avatar Feb 21 '23 18:02 Gudahtt

We should ensure that the extension team wishes to accept this change before we include it here. Just wanted to give you a heads up before you do more work on these tests, that it might be better to get buy-in from that team first.

Great point! We have already discussed with Alex Bea, Erikson, Kumavis, and Olaf to confirm their buy-in, along with our Metamask grant proposal. Feel free to tag any of them here to confirm!

Divide-By-0 avatar Feb 21 '23 18:02 Divide-By-0

Could you add the method as a PR to our api-specs repo as well: https://github.com/MetaMask/api-specs

shanejonas avatar Feb 21 '23 18:02 shanejonas

Thank you both for the great feedback!

  • @mcmire added some unit tests to src/wallet.test.ts
  • @shanejonas just opened https://github.com/MetaMask/api-specs/pull/120

rrrliu avatar Feb 23 '23 09:02 rrrliu