Add Paradigm hotlist
PR Title
Add Paradigm hotlist
Description
Adds the Paradigm hotlist to the list of phishing endpoints to check. This hotlist will be updated manually during security incidents, almost always by me personally.
-
ADDED:
- New endpoint to PhishingController
Checklist
- [x] Tests are included if applicable
- [x] Any added code is fully documented
Thanks for the PR, Sam! I added some tests and fixed some linting issues making it ready for review!
I wonder if we would prefer the Paradigm hotlist only including blacklist, similarly to the Phishfort list 🤔 Since changes to the fuzzylist has big implications for the functionality of the entire system.
cc @Gudahtt @409H
Thanks! Was meaning to get to the failing tests after I pushed out the project I was working on, but I see it probably would've taken a bit of time without any context.
I'm open to only including the blacklist if that would make things easier.
I agree with @FrederikBolding ; that would be much easier for us to manage. The fuzzylist has a high false-positive rate so we have to be very careful about expanding that.
Also, where should we direct users that want to dispute an entry on your list? We include a dispute link on our warning page, so we need one for each list. We use our eth-phishing-detect repo for disputes, and drop them straight into a partially-filled-out issue template. But a "contact" page or something would work too.
Updated. As for the redirect link, maybe the issues page too then.
Ah, that lint took a long time to fail. Will check it out. (e: seems like it's flakey?)
@samczsun-paradigm Looks like this needs a rebase after some changes were made to the PhishingController.