core
core copied to clipboard
Move ERC721 token URI parsing into try catch block
PR Title
Move ERC721 token URI parsing into try catch block
Description
Move ERC721 token URI parsing into try catch block. I included a test but can omit if deemed bloat.
-
FIXED:
- Not all contract token URIs are valid/can be fetched, and we should have backwards compatibility because they usually cannot be redeployed
Checklist
- [x] Tests are included if applicable
- [x] Any added code is fully documented
Issue
Resolves metamask-extension#14589
Note: the code in the try/block was introduced on March 3rd and I think it was a simple oversight to not have wrapped the entirety of the new code (because none of these variables are required)
@adonesky1 What do you think about this?
Closing as this was rectified in #834