core
core copied to clipboard
fix(bridge-status-controller)!: use SnapKeyring.submitRequest to dispatch Snap keyring requests
Explanation
I missed this when introducing the KeyringRequest.origin feature.
- https://github.com/MetaMask/core/pull/5871
The main problem is that this controller is dispatching "raw Snap request", thus, preventing any type-checking when doing keyring API updades.
By using SnapKeyring this should prevent this kind of problems in the future and it aligns well on how other controllers interact with the Snap keyring requests!
References
N/A
Changelog
Checklist
- [x] I've updated the test suite for new or updated code as appropriate
- [x] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
- [x] I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
- [ ] I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes
@metamaskbot publish-preview
@metamaskbot publish-preview
Preview builds have been published. See these instructions for more information about preview builds.
Expand for full list of packages and versions.
{
"@metamask-previews/account-tree-controller": "0.1.0-preview-ef0f18a",
"@metamask-previews/accounts-controller": "30.0.0-preview-ef0f18a",
"@metamask-previews/address-book-controller": "6.1.0-preview-ef0f18a",
"@metamask-previews/announcement-controller": "7.0.3-preview-ef0f18a",
"@metamask-previews/app-metadata-controller": "1.0.0-preview-ef0f18a",
"@metamask-previews/approval-controller": "7.1.3-preview-ef0f18a",
"@metamask-previews/assets-controllers": "68.1.0-preview-ef0f18a",
"@metamask-previews/base-controller": "8.0.1-preview-ef0f18a",
"@metamask-previews/bridge-controller": "32.1.1-preview-ef0f18a",
"@metamask-previews/bridge-status-controller": "29.1.0-preview-ef0f18a",
"@metamask-previews/build-utils": "3.0.3-preview-ef0f18a",
"@metamask-previews/chain-agnostic-permission": "0.7.0-preview-ef0f18a",
"@metamask-previews/composable-controller": "11.0.0-preview-ef0f18a",
"@metamask-previews/controller-utils": "11.10.0-preview-ef0f18a",
"@metamask-previews/delegation-controller": "0.4.0-preview-ef0f18a",
"@metamask-previews/earn-controller": "1.1.0-preview-ef0f18a",
"@metamask-previews/eip1193-permission-middleware": "0.1.0-preview-ef0f18a",
"@metamask-previews/ens-controller": "16.0.0-preview-ef0f18a",
"@metamask-previews/error-reporting-service": "1.0.0-preview-ef0f18a",
"@metamask-previews/eth-json-rpc-provider": "4.1.8-preview-ef0f18a",
"@metamask-previews/foundryup": "1.0.0-preview-ef0f18a",
"@metamask-previews/gas-fee-controller": "23.0.0-preview-ef0f18a",
"@metamask-previews/json-rpc-engine": "10.0.3-preview-ef0f18a",
"@metamask-previews/json-rpc-middleware-stream": "8.0.7-preview-ef0f18a",
"@metamask-previews/keyring-controller": "22.0.2-preview-ef0f18a",
"@metamask-previews/logging-controller": "6.0.4-preview-ef0f18a",
"@metamask-previews/message-manager": "12.0.1-preview-ef0f18a",
"@metamask-previews/multichain": "4.1.0-preview-ef0f18a",
"@metamask-previews/multichain-api-middleware": "0.4.0-preview-ef0f18a",
"@metamask-previews/multichain-network-controller": "0.8.0-preview-ef0f18a",
"@metamask-previews/multichain-transactions-controller": "2.0.0-preview-ef0f18a",
"@metamask-previews/name-controller": "8.0.3-preview-ef0f18a",
"@metamask-previews/network-controller": "23.6.0-preview-ef0f18a",
"@metamask-previews/notification-services-controller": "10.0.0-preview-ef0f18a",
"@metamask-previews/permission-controller": "11.0.6-preview-ef0f18a",
"@metamask-previews/permission-log-controller": "3.0.3-preview-ef0f18a",
"@metamask-previews/phishing-controller": "12.5.0-preview-ef0f18a",
"@metamask-previews/polling-controller": "13.0.0-preview-ef0f18a",
"@metamask-previews/preferences-controller": "18.1.0-preview-ef0f18a",
"@metamask-previews/profile-sync-controller": "17.0.0-preview-ef0f18a",
"@metamask-previews/queued-request-controller": "10.0.0-preview-ef0f18a",
"@metamask-previews/rate-limit-controller": "6.0.3-preview-ef0f18a",
"@metamask-previews/remote-feature-flag-controller": "1.6.0-preview-ef0f18a",
"@metamask-previews/sample-controllers": "0.1.0-preview-ef0f18a",
"@metamask-previews/seedless-onboarding-controller": "1.0.0-preview-ef0f18a",
"@metamask-previews/selected-network-controller": "22.1.0-preview-ef0f18a",
"@metamask-previews/signature-controller": "30.0.0-preview-ef0f18a",
"@metamask-previews/token-search-discovery-controller": "3.2.0-preview-ef0f18a",
"@metamask-previews/transaction-controller": "57.2.0-preview-ef0f18a",
"@metamask-previews/user-operation-controller": "36.0.0-preview-ef0f18a"
}