core icon indicating copy to clipboard operation
core copied to clipboard

feat: Add tokenSortConfig to preferences controller

Open gambinish opened this issue 1 year ago • 1 comments

Explanation

Adds a tokenSortConfig to PreferencesController to pair with mobile and extension codebases. This config will tell each application which keys tokens are sorted by, which order they are sorted in, and by which sorting callback they should use while being sorted.

References

https://consensyssoftware.atlassian.net/browse/MMASSETS-357 https://consensyssoftware.atlassian.net/browse/MMASSETS-356

Changelog

gambinish avatar Oct 01 '24 06:10 gambinish

Looks good! Can we update change log to reflect the update; sth like

@metamask/preferences-controller

  • Added: Added tokenSortConfig to preferencesController state

sahar-fehri avatar Oct 08 '24 14:10 sahar-fehri

Maybe we wont this one if this gets merged first https://github.com/MetaMask/core/pull/4860/files#diff-40a12640df782cc92dd07efa2b2f120024eb7c5cf1d9431893406ef39132e272

sahar-fehri avatar Oct 30 '24 08:10 sahar-fehri

Closed as change was included in https://github.com/MetaMask/core/pull/4860

cryptodev-2s avatar Oct 30 '24 22:10 cryptodev-2s