contract-metadata icon indicating copy to clipboard operation
contract-metadata copied to clipboard

Add DeCash token

Open nikitaeverywhere opened this issue 4 years ago • 9 comments

Hello! Adding a new token of a young project which is already present in the mainnet. Thanks for the review!

Website: https://www.decash.com/ Whitepaper: https://www.decash.com/white-paper/decash-white-paper.pdf Facebook: https://www.facebook.com/decash.transparently.stable Instagram: https://www.instagram.com/decash_official/ Twitter: https://twitter.com/DeCash_

Please let me know if you need any other information to add the token. Thanks!

nikitaeverywhere avatar Jun 01 '21 00:06 nikitaeverywhere

Ping @xrn is there anything that can be done from our side to speed this review up?

nikitaeverywhere avatar Oct 19 '21 13:10 nikitaeverywhere

Contract addresses are incorrect - for example this is correct DeCash CHFD address 0x2451287d7bd2FAD463095235ac706dFda2Bcd69D

xrn avatar Oct 19 '21 13:10 xrn

@xrn indeed, thank you! I had to reference proxy smart contracts instead. Now fixed, please approve!

nikitaeverywhere avatar Oct 19 '21 16:10 nikitaeverywhere

@davidwgrossman @xrn is there anything else to be done for this PR to be approved? Thanks!

nikitaeverywhere avatar Oct 21 '21 14:10 nikitaeverywhere

@xrn this PR is not invalid anymore, it was fixed 6 days ago. Would you be able please to approve it? Thanks!

nikitaeverywhere avatar Oct 25 '21 13:10 nikitaeverywhere

Hi @ZitRos looks like 0x4A33E0123e59a5874955B469ab2C0b626Bbf3670 is not a token address + activity on other addresses is very low

xrn avatar Oct 26 '21 05:10 xrn

Thanks @xrn! 0x4A33E0123e59a5874955B469ab2C0b626Bbf3670 is the same token as 3 others, however it hasn't been minted yet. What is the activity threshold you'd expect to add the token logo? How many transactions? Do you have a doc describing the requirements?

Thanks!

nikitaeverywhere avatar Oct 26 '21 07:10 nikitaeverywhere

@xrn I've removed 0x4A33E0123e59a5874955B469ab2C0b626Bbf3670 as indeed it has 0 tokens in circulation. Please note that our tokens are not community tokens and are issued by an institution DCIC Ltd instead, which are available at the moment only via OTC desk on instacoins.com. Please check this legal audit document and this page explaining the circulation.

I hope this is enough to merge this pull request, please comment if not.

nikitaeverywhere avatar Oct 26 '21 14:10 nikitaeverywhere

@xrn ping! Anything else needed to merge this pull request?

nikitaeverywhere avatar Nov 06 '21 12:11 nikitaeverywhere