mobile icon indicating copy to clipboard operation
mobile copied to clipboard

Switch workspace on invitation accepted

Open VitorVieiraZ opened this issue 8 months ago • 3 comments

  • Added workspaceId to InvitationsModel after /v1/workspace/invitations endpoint began including this field with each invitation. After accepting a workspace invitation, app now switches to accepted workspace and navigates to its project list if server version is bigger than 2025.4.1 ( see https://github.com/MerginMaps/server-private/issues/2936 ).
  • Added a new method serverVersionIsAtLeast to check whether server version meets or exceeds a required minimum version.
  • Changed icon of addIcon method in NotificationModel from WaitingIcon to InfoIcon.

Resolves #3847

VitorVieiraZ avatar May 12 '25 17:05 VitorVieiraZ

We should wait for server release before testing and merging this PR.

VitorVieiraZ avatar May 13 '25 07:05 VitorVieiraZ

Pull Request Test Coverage Report for Build 16593915130

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 249 unchanged lines in 8 files lost coverage.
  • Overall coverage increased (+0.2%) to 59.781%

Files with Coverage Reduction New Missed Lines %
input/core/merginuserinfo.h 1 0.0%
input/app/notificationmodel.h 4 50.0%
input/app/ios/iosutils.cpp 17 16.13%
input/core/merginuserinfo.cpp 24 77.12%
input/app/invitationsmodel.cpp 25 0.0%
input/app/main.cpp 29 33.71%
input/app/mmstyle.h 34 1.93%
input/core/merginapi.cpp 115 75.16%
<!-- Total: 249
Totals Coverage Status
Change from base Build 16592906352: 0.2%
Covered Lines: 8306
Relevant Lines: 13894

💛 - Coveralls

github-actions[bot] avatar May 15 '25 08:05 github-actions[bot]

Working on app.dev tests.

VitorVieiraZ avatar May 29 '25 08:05 VitorVieiraZ

When accepting the invitation, the view gets correctly moved to a correct screen. However I get offered public projects instead of the projects from that workspace and after a while the list disappears and notification about wrong URL is shown. Clicking retry fetches workspace projects.

https://github.com/user-attachments/assets/a6d50e81-0c02-4d36-b01f-6d2d2b7cb5c8

Withalion avatar Jul 03 '25 20:07 Withalion

As agreed on the call, let's use the logic only when accepting an invitation during the onboarding flow.

tomasMizera avatar Aug 04 '25 14:08 tomasMizera

Android - v694611, iOS - 25.8.790411: "Server is out of date" message once the app starts. Tried for app.dev and app:

Besides that, the invitations work fine, tested on iOS, Android 15 and Android 9. @Withalion @tomasMizera

RastoHu avatar Aug 25 '25 08:08 RastoHu

Do you get this also on other builds @RastoHu or only on this one?

tomasMizera avatar Aug 25 '25 10:08 tomasMizera

Do you get this also on other builds @RastoHu or only on this one?

also on 692611

RastoHu avatar Aug 25 '25 10:08 RastoHu