Do not center to geometry when highlighting when geometry does not fit the screen
This PR fix the ux-unfriendly behavior when in some scenario (concave shaped, or too big) the user would highlight a feature and the extend would either not move to the feature or move quite a lot.
The new behaviors works by not jumping to the feature if the feature can not be fully contained within the current extend size
Example both jumping and not jumping in the same video: Screencast from 2024-10-25 11-46-47.webm
Fix #3559
Pull Request Test Coverage Report for Build 13988228756
Details
- 0 of 0 changed or added relevant lines in 0 files are covered.
- 335 unchanged lines in 1 file lost coverage.
- Overall coverage increased (+0.08%) to 60.316%
| Files with Coverage Reduction | New Missed Lines | % |
|---|---|---|
| input/app/inpututils.cpp | 335 | 53.77% |
| <!-- | Total: | 335 |
| Totals | |
|---|---|
| Change from base Build 13947141497: | 0.08% |
| Covered Lines: | 8022 |
| Relevant Lines: | 13300 |
💛 - Coveralls
There is one things left that bother me, it's that in some cases you, since we don't offset the view, you can hide the highlighted feature with the pop-up, see the attached video
Screencast from 2024-10-28 15-34-54.webm
I am working on a fix but I can do it in a separate PR
please rebase to latest master