mergify Add condition attribute for unresolved PR comments

My org has a style of leaving final 'nit' comments and approving assuming they'll be fixed before merge but it seems there's no way to tell mergify to not merge if there are open comments.

The alternative would be to create a status check for open comments but it seems round about. :)

Thanks!

Sep 12 '20 07:09 melink14

Hi @melink14!

How do you recognize "open comments"?

Sep 12 '20 07:09 jd

Thanks for the reply.

I mean resolved vs unresolved in github parlance:

I was thinking that resolved might be the same as what's referred to by the dismissed-reviews-by but not 100% sure.

Sep 12 '20 07:09 melink14

They are not the same indeed, the dismissed-reviews-by or commented-reviews-by attributes are for the general review of the PR, not about individuals comments.

Sep 12 '20 07:09 jd

GitHub recently released branch protection against unresolved comments so this should work directly for users rely on them (I do).

(Of course, this is only after hours spent on a custom workflow...)

Jun 18 '21 03:06 melink14