Melkeydev
docker-react-nginx-config
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.
Problem
close #339
Description of Changes:
As described in the linked issue, we should not use Node for serving static assets.
Checklist
- [x] I have self-reviewed the changes being requested
- [x] I have updated the documentation (check issue ticket #218)
Just out of curiosity - is there any plans to expand this functionality? I'd typically reach for Caddy rather than nginx, for example. There are also other options such as Envoy which I currently use at work. Are we against turning this into a flag and having a few options for the user? (in the future, not suggesting a re-write of this PR)
@valxntine This is a great idea, and it could be done when we are redesigning the CLI. Frontend stuff will have a separate flag, and we can expand advanced flags when Docker and frontend are paired. Caddy and Traefik with automatic SSL are something that I would like to see implemented.