MediaInfo icon indicating copy to clipboard operation
MediaInfo copied to clipboard

24.06 - Open Preferences and click on "Adavanced" -> GUI buttons appear

Open Klaus1189 opened this issue 1 year ago • 14 comments

Open MediaInfo Open "Preferences" and click on "Advanced" then despite search is disabled and version is up to date buttons appear: 24 06 issue

And despite "toolbar" is disabled after closing the "Preferences" the toolbar is not hidden, only the buttons disappear but the place stays like it is still shown, but on only a cut off non-working orange button is shown is this area: button

Klaus1189 avatar Jun 28 '24 19:06 Klaus1189

There's another minor 'Preferences' window bug I found. When clicking 'More...' next to 'Language' on 'Setup' page, it goes to 'Customize' -> 'Graph'. I'm guessing it should be going to 'Customize' -> 'Language'.

Update: This one fixed by me.

cjee21 avatar Jun 29 '24 02:06 cjee21

And despite "toolbar" is disabled after closing the "Preferences" the toolbar is not hidden, only the buttons disappear but the place stays like it is still shown, but on only a cut off non-working orange button is shown is this area: https://drive.google.com/file/d/1AamHX_5Ql0HlsKfBwImyLM35kywfcHOE/view?usp=sharing

Steps to reproduce

  1. Open 'Preferences' -> 'Advanced'
  2. Disable 'Show toolbar' and click 'OK'
  3. Do step 1 again
  4. Click 'OK' without touching anything else

cjee21 avatar Jun 29 '24 02:06 cjee21

If you need anything in this issue, please let me know. Testing or anything, I do it for you.

And translation later, it will take some time. For RTSS and MSI Afterburner I also needed some time for full new translation: https://forums.guru3d.com/threads/german-translation.447957/

Klaus1189 avatar Jun 29 '24 16:06 Klaus1189

I wonder why many things seem to happen on the main window upon clicking advanced in preferences window. I don't see anything that may cause that in this function: https://github.com/MediaArea/MediaInfo/blob/dda61d6a99aa58fbf69b488669c2ac26242222b2/Source/GUI/VCL/GUI_Preferences.cpp#L629

cjee21 avatar Jun 30 '24 05:06 cjee21

Debugging results:

Open MediaInfo Open "Preferences" and click on "Advanced" then despite search is disabled and version is up to date buttons appear: 24 06 issue

When Advanced is clicked in Preferences, the Setup_AdvancedShow mentioned above is called. Then when this line is executed, https://github.com/MediaArea/MediaInfo/blob/223d9ae5844bc369545a9ef04c2b93847e6ce641/Source/GUI/VCL/GUI_Preferences.cpp#L632 what you see in the above screenshot appears (it is greyed out on standard theme, indicating that no new version is actually available). So it seems to be triggered by something in Prefs? In that case I will not be digging further. I took a look at Prefs area before to figure out how language files get duplicated but gave up. @JeromeMartinez should assign someone else.

cjee21 avatar Jun 30 '24 11:06 cjee21

@JeromeMartinez should assign someone else.

for me.

JeromeMartinez avatar Jun 30 '24 12:06 JeromeMartinez

So it seems to be triggered by something in Prefs?

@JeromeMartinez Upon further testing, it appears to not be caused by Prefs.

I changed

https://github.com/MediaArea/MediaInfo/blob/223d9ae5844bc369545a9ef04c2b93847e6ce641/Source/GUI/VCL/GUI_Preferences.cpp#L632

to

CB_ShowMenu->Checked=1;

and it still happens. It won't let me step into this line so I cannot check further.

cjee21 avatar Jul 01 '24 01:07 cjee21

@JeromeMartinez While looking around for something else, found the cause of the orange button partially visible in 2nd screenshot of first post...

This is hiding behind there (a second, unnamed 'Donate' button?): Screenshot 2024-07-01 205301

cjee21 avatar Jul 01 '24 12:07 cjee21

This is hiding behind there (a second, unnamed 'Donate' button?):

It is from a very old code with buttons for donation, actually they should be deleted now. Need to take time for big cleanup of that.

JeromeMartinez avatar Jul 01 '24 16:07 JeromeMartinez

This is hiding behind there (a second, unnamed 'Donate' button?):

It is from a very old code with buttons for donation, actually they should be deleted now. Need to take time for big cleanup of that.

I helped removed the donate buttons and their related codes. Also done some clean-up and re-organization of codes.

Partially fixed this issue also. Now the GUI is properly displayed after Preferences window is closed. However, when Preferences->Advanced is open, the issue mentioned is still there including the toolbar being displayed even when unchecked.

cjee21 avatar Jul 02 '24 02:07 cjee21

I just tested 24.12 and issue still persists.

Klaus1189 avatar Dec 10 '24 17:12 Klaus1189

I just tested 24.12 and issue still persists.

That is expected. No one did anything about it that is why this issue is still open.

cjee21 avatar Dec 10 '24 17:12 cjee21

OK

Klaus1189 avatar Dec 10 '24 17:12 Klaus1189

@Klaus1189 Most of the issues mentioned above should be no longer present in ~the latest development build: https://mediaarea.net/download/snapshots/binary/mediainfo-gui/20250319-2/MediaInfo_GUI_24.12.20250319_Windows.exe~ 25.03

cjee21 avatar Mar 19 '25 15:03 cjee21