MediaConch_SourceCode icon indicating copy to clipboard operation
MediaConch_SourceCode copied to clipboard

MediaConchFirstPass display option

Open dericed opened this issue 9 years ago • 18 comments

dericed avatar Jan 15 '17 06:01 dericed

Oo la la

ablwr avatar Jan 15 '17 15:01 ablwr

Yes! Tested all of these and look good to me. 👍

ablwr avatar Jan 15 '17 16:01 ablwr

What is the purpose of MediaConchFirstPass.xsl? It is not clear, and we are missing a "description" block.

JeromeMartinez avatar Jan 16 '17 10:01 JeromeMartinez

It is for some characterization, but the policy is set up differently. It would be like:

<policy type="or" name="categorize these files">
 <policy type="and" name="Final Cut Capture">...</policy>
 <policy type="and" name="Camera Recording">...</policy>
 <policy type="and" name="Final Cut Export">...</policy>
 <policy type="and" name="Unknown File">...</policy>
</policy>

output would be:

filename1,Final Cut Capture
filename2,Unknown file
filename3,Camera Recording
filename4,Camera Recording

dericed avatar Jan 16 '17 12:01 dericed

I think MediaConchFirstPass should have a more relevant name. Not sure of which one, but here this is not clear.

JeromeMartinez avatar Jan 16 '17 12:01 JeromeMartinez

FirstPass is meaning First Passing sub-policy or rule, but sure the naming could be improved. @ablwr?

dericed avatar Jan 16 '17 12:01 dericed

FirstToPass or QuickPass? Although unsure if it is actually much 'quicker'...

It seems like a FirstFail would be more useful?

ablwr avatar Jan 16 '17 14:01 ablwr

It is not quicker, so -1 for it. FirstToPass: First what? --> FirstRuleToPass? (even if "Rule" is technically not correct because it is sub-policy or rule, the idea is there)

JeromeMartinez avatar Jan 16 '17 14:01 JeromeMartinez

Does the user interact with the file name? I don't think CSV and First2Pass make much sense in the GUI where a report is viewed for a single record at a time. But how should these be in the CLI?

MediaConchCSV

  • mediaconch -p policy.xml -fc some.mov files.mkv > yay.csv

MediaConchSimple

  • mediaconch -p policy.xml -fs some.mov files.mkv

For scalability perhaps we should have long names as alias.

  • -fx = --format xml = --format x etc

dericed avatar Jan 17 '17 14:01 dericed

-fx == --format=xml (which already exists) -fc == --format=csv -fs == --format=simple ?

ablwr avatar Jan 17 '17 14:01 ablwr

But what is the use case for FirstPass (to be renamed or not)?

ablwr avatar Jan 17 '17 14:01 ablwr

todo: documentation, but generally the idea is to categorize media with a set of top-level policies and report on the first matching one. Some top level policies to detect if it is final cut capture, then another for media express capture, an access file, a mezzanine, etc. Then if you have a large set of random files this policy would group them by a type.

dericed avatar Jan 17 '17 15:01 dericed

I see. Contingent on this very specific use case of the first policy being the most important and set up in this particular way so that it may direct files out accordingly.

ablwr avatar Jan 17 '17 15:01 ablwr

A bit inspired by the archivematica FPR as they have to categorize files and act according to that. The semantics are a bit off in this case though as pass/fail doesn't seem as appropriate, but it's more like match/not-match.

dericed avatar Jan 17 '17 15:01 dericed

From my point of view FirstPass is too much specific (and looks like an hack :) ), and should not be in the default installation, but should go in a "public display" page (@GuillaumeRoques will like the idea ;-) ).

Each display has some concerns (e.g. CSV output would not work well when we get 2 implementation checkers and 2 formats are in the list of parsed), I suggest to open 1 PR per display in order to not mix discussions.

JeromeMartinez avatar Jan 18 '17 07:01 JeromeMartinez

Right, csv presumes the values of the first implementation check for each subsequent file. I could restrict it to Matroska. I can split the PR tonight.

dericed avatar Jan 18 '17 17:01 dericed

CSV and Simple are added (https://github.com/MediaArea/MediaConch_SourceCode/pull/522, https://github.com/MediaArea/MediaConch_SourceCode/pull/523, https://github.com/MediaArea/MediaConch_SourceCode/pull/524).

I let this one open for discussion about MediaConchFirstPass.xsl. Issue:

  • looks like a (good) hack, maybe not for general availability but for a public display page. In the meanwhile it could be used by sending the XSL to the interested people.
  • Shouldn't we ad somewhere a description, with some indication about the purpose of the XSL? I am afraid that someone new can not understand it. then we could e.g. add an help option that provides this description with the command line (and the GUI could have a tooltip, for other displays)

JeromeMartinez avatar Jan 24 '17 18:01 JeromeMartinez

This is old.

ablwr avatar Apr 18 '17 00:04 ablwr