tvb-ukbb icon indicating copy to clipboard operation
tvb-ukbb copied to clipboard

inconsistent variable names, script names & hard-coded things

Open shen4brains opened this issue 5 years ago • 3 comments

Things to clean up:

  • [ ] subject directory variable naming conventions (e.g., $subjdir, $direc, $baseDir are all used to mean the same directory)
  • [ ] turn off verbose mode in bb_eddy_wrap and bb_probtrackx2
  • [x] rename TVB team scripts with 'tvb_' prefix (e.g., probtrackx scripts)
  • [ ] rename IDP pipeline bb_IDP.py to be consistent with other subpipes

Hard-coded things to fix:

  • [ ] B0 extraction in diffusion subpipe << This is an issue for the odd case where B0 isn't the first volume
  • [ ] acqparams.txt contents in bb_pre_eddy

shen4brains avatar Dec 07 '20 22:12 shen4brains

Also some typos that don't affect pipeline function:

  • [ ] extra subject name argument in FEAT job submission in bb_pipeline_func in both ADNI3 and master branches

shen4brains avatar Jan 19 '21 16:01 shen4brains

Also need to check for consistent labelling of QC report with pipeline sections (e.g., 'dMRI' not 'DTI', 'structural' not 'anatomical') @justinliuyuwang

shen4brains avatar Apr 27 '21 19:04 shen4brains

And make logging of jobFC equivalent to other logs (missing header and footer?)

shen4brains avatar Jun 02 '21 20:06 shen4brains