Max Anderson
Max Anderson
Sorry for the notification spam. I screwed up trying to fix a merge conflict. Anyway I think we're good now.
@migruiz4 sorry to bother, but do you mind re-reviewing the changes you requested? I keep having to re-base this PR because changes are being made in other branches.
Just hit this bug ourselves. Seeing logs where the app controller is failing to acquire a token because its using the wrong URL: ```json {"level":"fatal","msg":"failed to acquire token. unable to...
> Is there a chance this gets in before Argo 3.1 [#23347](https://github.com/argoproj/argo-cd/issues/23347)? It looks like PR #23004 was merged into the `release-3.0` branch so let's hope 🤞🏻
I think this is fixed in `v3.1.0-rc1` according to the diffs but I haven't been brave enough to try it yet, and haven't had time to setup a test environment.
Can confirm running `v3.0.11` is working great for us.
Hi @crenshaw-dev is it possible to get this PR reviewed?
> Folks have said that the latest versions on HEAD work. Should we use those instead? Yeah it looks like the version in HEAD are: ``` github.com/Azure/azure-sdk-for-go/sdk/azcore v1.18.0 github.com/Azure/azure-sdk-for-go/sdk/azidentity v1.10.0...
@cheinema Unless I'm missing something, the [v0.14.2 release](https://github.com/kubernetes-sigs/external-dns/blob/e490412e6c44459524147febd140f4584d266fc5/charts/external-dns/crds/dnsendpoint.yaml#L6) appears to have the fix. Is there anything else that needs to be done before merging the fix into the chart?
@rouke-broersma I knew I was missing something! Thanks.