Polykey icon indicating copy to clipboard operation
Polykey copied to clipboard
verified publisher icon MatrixAI

Use of `ctx` when for `identities` `Provider.authenticate` Interface

Open amydevs opened this issue 2 years ago • 1 comments

Specification

Currently Provider.authenticate has number timeout parameter. This is a leftover from how the identities domain was initially implemented. This will need to be changed to a ctx to be inline with how timeouts are now handled in the rest of PK.

Additional context

This will have some implications detailed here:

https://github.com/MatrixAI/Polykey-CLI/pull/49

Tasks

  1. Change Provider.authenticate to use ctx
  2. Update GitHubProvider to match
  3. Update related identities tests

amydevs avatar Nov 10 '23 04:11 amydevs

What happened to this @amydevs?

CMCDragonkai avatar Aug 22 '24 11:08 CMCDragonkai