patchdemo icon indicating copy to clipboard operation
patchdemo copied to clipboard

Parsoid not working when building wiki with 1.38.0-wmf.1

Open edg2s opened this issue 4 years ago • 6 comments

Example: https://patchdemo.wmflabs.org/wikis/8eae561eea/wiki/Main_Page?veaction=edit

edg2s avatar Jan 20 '22 16:01 edg2s

It should be responding with HTML here: https://patchdemo.wmflabs.org/wikis/8eae561eea/w/rest.php/v1/page/Main_Page/html …But instead I see:

{"messageTranslations":{"en":"Unable to fetch Parsoid HTML"},"httpCode":501,"httpReason":"Not Implemented"}

MatmaRex avatar Jan 25 '22 23:01 MatmaRex

There is no wmf/1.38.0-wmf.1 branch in the mediawiki/services/parsoid repo, so it is not checked out, so we should be using Parsoid via Composer instead. I guess that doesn't work for some reason.

MatmaRex avatar Jan 25 '22 23:01 MatmaRex

I don't know why and I'm not particularly thrilled to investigate…

MatmaRex avatar Jan 26 '22 00:01 MatmaRex

CC @cscott

edg2s avatar Jan 26 '22 15:01 edg2s

The dependency on the master branch should be to "wikimedia/parsoid": "^0.15.0-a1@alpha" which will be the most recent released version of parsoid. But we don't maintain backward compatibility to old wmf.1 branches. You probably want to checkout mediawiki-vendor for wmf/1.38.0-wmf.1 and use the packages from there. Looking at that branch, if appears parsoid 0.14.0-a19 is the one to use -- we were a little late cutting out 0.15 branch and the first wmf.1 snuck out with a 0.14 build.

cscott avatar Jan 26 '22 16:01 cscott

Sounds like this might just be a one off with this particular branch then? If that's the case then I'm fine with ignoring it..

edg2s avatar Jan 26 '22 18:01 edg2s