MathisGD comments

Results 22 comments of


                                            MathisGD

expectedSupplyAssets behaving differenly locally and in CI-CD pipeline (gitlab)

Feel free to reach out if you still have issues

Inconsistent naming of "MainnetLib"

So we modify the contract without redeploying it? Then I would also modify "BaseBundler"

Inconsistent naming of "MainnetLib"

Why not renaming the "BaseBundler"?

include ERC72.huff got duplicate macro name

I believe that this is linked to the change in huffc which raises an error when there are duplicate macros in a compiled file (including imports), while in the past...

feat(cheatcodes): add `vm.storeTransient` and `vm.loadTransient`

It would be great to have a vm.clearTransientStorage() cheat as well, like mentioned here: https://github.com/foundry-rs/foundry/issues/6908

Fix: total supply overflow

> There are two APPROVE() macros. Removed the old incorrect macro. I opened an [issue](https://github.com/huff-language/huff-rs/issues/291) on huff-rs for this.

scripts: deployer of script contract is not msg.sender

EOAs can't directly use CREATE2, although they can call a contract that does a CREATE2. When a CREATE2 is in a forge script, the transaction is actually a call to...

Tracking: Use Solar for Solidity AST

Hey @DaniPopes! When do you plan to do the refactor for `fmt`? Otherwise do you think that this could be a first good issue? Note that fmt stills breaks with...

Call to permit() will kill previous allowances of the spender

This would break [EIP-2612](https://eips.ethereum.org/EIPS/eip-2612) Also you wouldn't be able to decrease the allowance using permit (not sure that there is a use-case for this, but flagging anyway).

Selecting a single test makes forge fail with `no matching artifact found`

Hey @grandizzy! When is the fix planned? This is basically making `--mt` `--mc` or `--rerun` unusable if you have one single deployment through getCode, which is quite annoying... Thanks in...