materialize icon indicating copy to clipboard operation
materialize copied to clipboard

postgres-util: refactor implementation to use openssh instead

Open andrioni opened this issue 3 years ago • 2 comments

Refactor implementation of SSH tunnels to use openssh instead of async-ssh2-lite due to the issues we've been facing so far.

I'll add tests here soon, I just wanted to get more eyes on it soon, because jetlag.

Motivation

  • This PR fixes a recognized bug: #14566

Checklist

andrioni avatar Sep 20 '22 16:09 andrioni

FYI, I should push the fixes for the comments as soon as I fix the mzcompose test failure: it's something to do with the permissions when openssh reads the key in the container. It's probably something obvious that I'm forgetting, it just takes a while because I have to build a clean docker image to test things.

andrioni avatar Sep 21 '22 18:09 andrioni

@andrioni sounds like a great plan!

guswynn avatar Sep 21 '22 18:09 guswynn

OK, the issue was completely different, we just didn't have openssh installed in the container 🤦.

Added tests for Postgres with SSL, and merging.

andrioni avatar Sep 22 '22 13:09 andrioni

🎉

guswynn avatar Sep 22 '22 15:09 guswynn