Fix Enhance Mouseover Visuals for TabControl
fixes #3802
- Sets the
Cursor="Hand"when hovering over aTabItem - Added the same "hover effect" to
TabItemwhich any normalButtonhas
Current behavior
New behavior
Adding a highlight to the tab header on mouse-hover makes sense. However changing the mouse cursor does not follow the WPF framework defaults for the for tab control. I also checked winforms and winUI, neither change the mouse cursor when hovering over a tab item (provided default styles are applied).
I would argue WPF defaults don't matter. The purpose of this library is to bring Material Design to WPF, and the MD specs suggest what is proposed in this PR (as far as i have read it). https://m3.material.io/components/tabs/accessibility#1f5832f9-1898-4da1-bfe4-f40c84027f8a
- I added a new attached property called
TabAssist.TabHeaderCursor - The new default
Cursoris theHand - Consumers can force the old
Cursorby setting the AP (e.g.:materialDesign:TabAssist.TabHeaderCursor="Arrow")
I would argue WPF defaults don't matter. The purpose of this library is to bring Material Design to WPF, and the MD specs suggest what is proposed in this PR (as far as i have read it). https://m3.material.io/components/tabs/accessibility#1f5832f9-1898-4da1-bfe4-f40c84027f8a
I agree with @corvinsz. And often when I am in doubt when looking at the MD3 specs, I drop back to the MD2 specs where they have the interactive demos for many things. And that clearly shows the hand cursor on hover: https://m2.material.io/components/tabs#interactive-demo