Masterminds
fix: update to mergo 1.0.0
@mattfarina Can we get this merged? This fixes a larger issue rather than just bumping up the version of mergo 1.0.0. Mergo switched their repo url from a gh url to a vanity url. See here: https://github.com/darccio/mergo/issues/245
@mattfarina please merge. The current experience is rather painful, even when that's an upstream issue:
go get -u
go: github.com/imdario/[email protected]: parsing go.mod:
module declares its path as: dario.cat/mergo
but was required as: github.com/imdario/mergo
trying github.com/imdario/[email protected]
Note that readme also has this:
Sprig leverages mergo to handle merges. In its v0.3.9 release, there was a behavior change that impacts merging template functions in sprig. It is currently recommended to use v0.3.10 or later of that package. Using v0.3.9 will cause sprig tests to fail.
Not sure if upgrading to post 0.3.11 would break anything? Is fixing this a prerequisite?
please merge this. its extremely annoying and its breaking random tooling such as renovate
Using v0.3.9 will cause sprig tests to fail.
@mattfarina I've re-run the tests on mergo 1.0- all fine:
sprig mergo
❯ grb master
Current branch mergo is up to date.
sprig mergo
❯ got ./...
ok github.com/Masterminds/sprig/v3 4.329s
For anyone impacted, add the following line at the bottom of go.mod in the meantime:
replace github.com/imdario/mergo => dario.cat/mergo v1.0.0
For anyone impacted, add the following line at the bottom of
go.modin the meantime:replace github.com/imdario/mergo => dario.cat/mergo v1.0.0
FWIW this doesn't actually work if your users do go install your-tool
I think this needs be removed if no longer an issue:
IMPORTANT NOTES Sprig leverages mergo to handle merges. In its v0.3.9 release, there was a behavior change that impacts merging template functions in sprig. It is currently recommended to use v0.3.10 or later of that package. Using v0.3.9 will cause sprig tests to fail.
A fork is being considered, interested community members should consider adding their efforts there https://github.com/Masterminds/sprig/issues/396
