html5-php Rename HTML to Html to follow PSR

Mar 17 '15 08:03 kandy

Big BC break, for a really small benefit. Maybe with 3.0... not planned yet.

Mar 17 '15 10:03 goetas

So, can I fork it, rewrite and publish with my VendorName?

Mar 17 '15 11:03 kandy

You may always fork it. But packagist.org discourages submitting forks (see here)

Do not submit forks of existing packages. If you need to test changes to a package that you forked to patch, use VCS Repositories instead

BTW, PRS-0 says notthing about the "char-case" of namespace.

Alphabetic characters in vendor names, namespaces, and class names may be of any combination of lower case and upper case.

BTW i do not see a big deal of having a different naming for the namespace.

Mar 17 '15 11:03 goetas

@goetas I believe the issue is on PSR-1 where it notes classes must use StudlyCaps. I ran into this on a UUID library I worked on where the expectation was Uuid would be used. You can see this on libraries like symfony/yaml (where yaml is Yaml).

If this were to be done it would need to be done in the 3.x.x version of the library per semantic versioning. It's an API breaking change.

Poking around at libraries I found Html was common but HTML was in use as well.

Because of the type of change, this should only happen when other API breaking changes are worked on pushing for a 3.0.0 release. Since we don't have any of those I would think it would be some time before we change this.

Mar 17 '15 16:03 mattfarina

@mattfarina Can we release the 3.0 right now (I mean the next week as example...)? (same as guzzle 5 that was released some weeks after the 4.0 release...)

Mar 17 '15 16:03 goetas

@goetas I don't see why couldn't do a 3.0 release soon. I would like to hear @technosophos weight in. Is there any other API breaking change you would want to see?

Mar 17 '15 19:03 mattfarina

Ugh... yet another PSR that requires dumb changes. I so much love introducing compatibility-breaking changes in the name of sticking with yet another arbitrary decision. sigh

I would be okay with doing a quick release and then renaming.

Mar 18 '15 14:03 technosophos

I do not have any other change to introduce... except of renaming the HTML class.

Mar 18 '15 22:03 goetas

I just release 2.1.1 with the latest bugfix.

Now is the time if someone wants to roll a 3.0.0 with this change. Any takers? I don't have time right now.

Mar 23 '15 23:03 mattfarina

@goetas is there anything else to finish the HTML5 to Html5 rename?

Jun 02 '15 00:06 mattfarina

@mattfarina Rebased the PR right now. I think that it is ready to be merged. Does it looks good to you?

Jun 07 '15 08:06 goetas

This has been merged and will go out in a 3.0.0 release.

Jun 19 '15 20:06 mattfarina

The work on 3.0 has ben stopped as there were no changes worth breaking compatibility, re opening this to keep tack of the feature request

Nov 23 '18 08:11 goetas