SimpleWebAuthn icon indicating copy to clipboard operation
SimpleWebAuthn copied to clipboard
verified publisher icon MasterKale

`devicePublicKey` => `devicePubKey`

Open agektmr opened this issue 3 years ago • 2 comments

Trivial update aligning the extension name to the spec.

agektmr avatar Aug 09 '22 05:08 agektmr

Hmm, there are a few unit tests that continue to reference the now "old" value devicePublicKey:

Screen Shot 2022-08-09 at 9 10 50 AM

Can you update these tests so everything refers to this extension as devicePubKey as well?

MasterKale avatar Aug 09 '22 16:08 MasterKale

Sorry, I overlooked your comment. Will fix them.

agektmr avatar Aug 11 '22 06:08 agektmr

@MasterKale Updated the tests. Can you check?

agektmr avatar Aug 16 '22 04:08 agektmr

lgtm :shipit:

MasterKale avatar Aug 16 '22 04:08 MasterKale

There's no issue associated with this so I'll let you know here that this is now available in @simplewebauthn/[email protected].

MasterKale avatar Aug 16 '22 05:08 MasterKale