marquez icon indicating copy to clipboard operation
marquez copied to clipboard

Upgrade/drop wizard 4.0.13

Open swar00pduthks opened this issue 9 months ago • 6 comments

Problem

👋 Thanks for opening a pull request! Please include a brief summary of the problem your change is trying to solve, or bug fix. If your change fixes a bug or you'd like to provide context on why you're making the change, please link the issue as follows:

Closes: Security Vulnerabilities Fixes #3040

Solution

upgraded drop wizard to 4.0.13 and to JakartaEE

One-line summary:

Checklist

  • [ X] You've signed-off your work
  • [ X] Your changes are accompanied by tests (if relevant)
  • [ ] Your change contains a small diff and is self-contained
  • [ ] You've updated any relevant documentation (if relevant)
  • [ ] You've included a one-line summary of your change for the CHANGELOG.md (Depending on the change, this may not be necessary).
  • [ ] You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • [ ] You've included a header in any source code files (if relevant)

swar00pduthks avatar Apr 28 '25 23:04 swar00pduthks

Thanks for opening your first pull request in the Marquez project! Please check out our contributing guidelines (https://github.com/MarquezProject/marquez/blob/main/CONTRIBUTING.md).

boring-cyborg[bot] avatar Apr 28 '25 23:04 boring-cyborg[bot]

Deploy Preview for peppy-sprite-186812 canceled.

Name Link
Latest commit 6a26a6ad2fc065dfc0e2388b0262396eed7afd24
Latest deploy log https://app.netlify.com/projects/peppy-sprite-186812/deploys/682a1f96b016df0008762449

netlify[bot] avatar Apr 28 '25 23:04 netlify[bot]

Codecov Report

Attention: Patch coverage is 71.27660% with 27 lines in your changes missing coverage. Please review.

Project coverage is 81.21%. Comparing base (a89b89c) to head (6a26a6a).

Files with missing lines Patch % Lines
...main/java/marquez/client/models/MarquezClient.java 0.00% 24 Missing :warning:
api/src/main/java/marquez/MarquezApp.java 80.00% 1 Missing :warning:
...c/main/java/marquez/api/ColumnLineageResource.java 97.36% 0 Missing and 1 partial :warning:
...rc/main/java/marquez/tracing/TracingSQLLogger.java 0.00% 1 Missing :warning:
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3056      +/-   ##
============================================
+ Coverage     81.18%   81.21%   +0.02%     
- Complexity     1506     1513       +7     
============================================
  Files           268      270       +2     
  Lines          7356     7426      +70     
  Branches        325      326       +1     
============================================
+ Hits           5972     6031      +59     
- Misses         1226     1237      +11     
  Partials        158      158              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Apr 28 '25 23:04 codecov[bot]

@wslulciuc @julienledem @roaraya8 @sshah-wework @ashulmanWeWork @hougs @mell0kat @jhubley @grantdfoster @phixMe @henneberger @mobuchowski @collado-mike @KevinMellott91 @merobi-hub @rossturk @fm100 @pawel-big-lebowski would you please help to review this big merge request for upgrade to drop wizard

swar00pduthks avatar May 18 '25 18:05 swar00pduthks

@swar00pduthks Thanks for that. Awesome work!

We adopter it here https://github.com/ilum-cloud/marquez/

thijs-s avatar Sep 19 '25 13:09 thijs-s

@swar00pduthks Thanks for that. Awesome work!

We adopter it here https://github.com/ilum-cloud/marquez/

Not sure how long will it take to merge to main branch but good to know it's been adapted. Thanks

swar00pduthks avatar Sep 19 '25 14:09 swar00pduthks