marquez icon indicating copy to clipboard operation
marquez copied to clipboard

Docker up script fails if parent folder is not named "marquez"

Open rossturk opened this issue 3 years ago • 1 comments

To save typing, I check out the Marquez repo into a folder called mqz:

git clone [email protected]:marquezproject/marquez.git mqz

I noticed that on the systems where I do this, I can't get the docker/up.sh script to complete successfully. If I check it out into a folder called marquez, it works.

Here's a video where I reproduce this issue:

https://user-images.githubusercontent.com/1434475/214937591-c20155f7-c95c-42fc-ba05-d9a8880e29fa.mov

rossturk avatar Jan 26 '23 19:01 rossturk

Can confirm this is still an ongoing issue

seanmullane avatar Sep 27 '24 21:09 seanmullane

In docker/up.sh, we change to the project root directory with:

# Change working directory to project root
project_root=$(git rev-parse --show-toplevel)
cd "${project_root}/"

When we run $(git rev-parse --show-toplevel) locally for the project root, I see:

/Users/wsl/dev/io.marquezproject/mqz

This issue is that we hardcode the docker volume prefix to marquez in stead of using the base directly of project_root.

wslulciuc avatar Oct 23 '24 21:10 wslulciuc