markbind icon indicating copy to clipboard operation
markbind copied to clipboard

Lower (white) navbar gets printed on mobile

Open jovyntls opened this issue 3 years ago • 5 comments

Please confirm that you have searched existing issues in the repo

Yes, I have searched the existing issues

Any related issues?

No response

Tell us about your environment

Safari / iOS 16.2

MarkBind version

4.0

What did you do? Describe the bug

Try to print a page on mobile. The white navbar gets printed, but it should not get printed.

Steps to reproduce

  1. Try to print a page on mobile
  2. (Optional) Scroll down The white navbar will be printed on wherever you scroll down to

Expected behavior

The white navbar should not be printed:

Actual behavior

The white navbar appears:

IMG_3513

Suggested solution

Adding a d-print-none class to the lower navbar should exclude this from printing

jovyntls avatar Jan 26 '23 06:01 jovyntls

Hey @jovyntls I cant see such issue. can you provide a screen recording of the issue you are facing?

shyamtawli avatar Jan 26 '23 12:01 shyamtawli

Hi @shyamtawli , check out this video:

https://user-images.githubusercontent.com/61113575/214844568-305e4c7d-de0d-4623-912f-fef03962825a.mov

You can see the white bar obstructing the print PDF. The same applies for mobile. Let me know if you have any trouble reproducing!

jovyntls avatar Jan 26 '23 13:01 jovyntls

@jovyntls I am not getting such issue. Maybe it is related to something else.

shyamtawli avatar Jan 27 '23 13:01 shyamtawli

@jovyntls I am not getting such issue. Maybe it is related to something else.

Perhaps provide a recording showing how you tested it out so that it's clear if there's any issue with the reproduction. Note that the page has to have site navigation, and the browser width should be reduced so that the hamburger menu appears

tlylt avatar Jan 27 '23 14:01 tlylt

I can reproduce this issue. I will look into it. Screenshot 2024-02-04 at 22 43 24

Tim-Siu avatar Feb 04 '24 14:02 Tim-Siu