csla icon indicating copy to clipboard operation
csla copied to clipboard

Implement parameter overloads for sync data portal Execute methods

Open rockfordlhotka opened this issue 3 years ago • 7 comments

https://github.com/MarimerLLC/csla/issues/1775 adds the ability to pass parameters to ExecuteAsync. This needs to be added to the sync Execute methods as well.

rockfordlhotka avatar Dec 24 '22 02:12 rockfordlhotka

@rockfordlhotka Is there any ETA for this? With it being an oversight from the last release, I was hoping that it would be added to a service release. I only ask, because as I convert my project to CSLA 6, I would like to convert my Commands to this new methodology for both sync and async, but because sync isn't there yet, I've been having to stick with the old methodology.

mtavares628 avatar Mar 13 '23 19:03 mtavares628

I am working on it currently. It isn't easy to implement.

rockfordlhotka avatar Apr 19 '23 01:04 rockfordlhotka

No worries. My apologies. I didn't realize the the level of effort for it. I thought it may have just been an oversight in terms of checking in the code when you had completed it for the async version. Thanks for putting in the time.

mtavares628 avatar Apr 19 '23 01:04 mtavares628

I want to do it right, and that is turning out to be more work than expected.

rockfordlhotka avatar Apr 19 '23 02:04 rockfordlhotka

I'm sorry @mtavares628 - I think I conflated two different things.

What I'm working on that's very hard is making modern concepts work in ObjectFactory: #1707

What you are talking about is a simpler issue: (this thread). I just haven't had time to get to the sync Execute changes.

rockfordlhotka avatar Apr 19 '23 16:04 rockfordlhotka

@rockfordlhotka no worries. I just saw that you bumped #1707 to v8 and that this issue has also been removed from v7. Will this also be bumped to v8 or is this more of a v7.0.1 issue?

mtavares628 avatar Apr 19 '23 17:04 mtavares628

Ha! You literally caught me mid-planning as I move things around 😳

Yes, I expect this is a 7.1.0 thing - I just need to get 7.0.0 moving - for my own sanity if nothing else.

rockfordlhotka avatar Apr 19 '23 17:04 rockfordlhotka