csla icon indicating copy to clipboard operation
csla copied to clipboard

Linux build fails because pt-BR not found

Open rockfordlhotka opened this issue 3 years ago • 1 comments

This issue is back in version 5.5.3 (5.4.0 until 5.5.2 seems to be ok), breaking Linux / Docker builds.

image (screenshot from version 5.5.3 using the NuGet Package explorer)

In version 6 the issue is not present, but we can't upgrade to that version just yet. Can this be fixed in the v5 branch again?

Originally posted by @PieterBoeren in https://github.com/MarimerLLC/csla/issues/1845#issuecomment-1144465833

rockfordlhotka avatar Jun 06 '22 18:06 rockfordlhotka

@pieterboeren I can't say when I'll get to this, as my next 2-3 weeks are very busy. If you want to submit a PR please do so.

rockfordlhotka avatar Jun 06 '22 20:06 rockfordlhotka

@PieterBoeren I don't see how to fix this - the file in GitHub does have the proper casing.

https://github.com/MarimerLLC/csla/blob/main/Source/Csla/Properties/Resources.pt-BR.resx

rockfordlhotka avatar Aug 17 '22 19:08 rockfordlhotka

The casing of the file (https://github.com/MarimerLLC/csla/blob/v5.x/Source/Csla.Shared.Resources/Resources.pt-BR.resx, the issue is in the 5.x branch, but the casing is correct here) was changed at some point. Isn't it just something like the casing is not updated on disk since the NuGet package is being published from a Windows machine (where Git doesn't really "see" casing changes)?

PieterBoeren avatar Aug 18 '22 06:08 PieterBoeren

Hmm. On my local clone the casing looks right.

image

rockfordlhotka avatar Aug 18 '22 22:08 rockfordlhotka

Maybe check what happens if you pack it again (I guess the issue can be validated without actually pushing a new version)? I wanted to do it myself, but I gave up since my Visual Studio encountered a lot of not installed frameworks and workloads :(

PieterBoeren avatar Aug 19 '22 11:08 PieterBoeren

I can't really test this, as I don't use a Linux build agent, so I'm going to close it for now.

rockfordlhotka avatar Aug 27 '22 23:08 rockfordlhotka

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

github-actions[bot] avatar Feb 24 '23 00:02 github-actions[bot]